Bugzilla – Bug 1464
no linebreack in IE filediff page
Last modified: 2012-01-31 17:50:14 EST
When rendering a diff in IE (5.5 -> 8) line breaks are not displayed, displaying the diff in one line (browsershot shows that IE8 display nothing). The first bad revision is: 03b60f2f90bf author Brendan Cully <brendan@kublai.com> date Thu Nov 20 18:15:50 2008 -0800 (7 weeks ago)
Hm, yeah, I noticed that a couple of days ago. The problem can currently be seen on http://www.selenic.com/hg/index.cgi/rev/03b60f2f90bf It seems like the markup intentionally puts IE in quirks mode, but in that mode white-space: pre; doesn't work. Solving this requires a browser/CSS guru. My naive guess of a solution would be to change the markup to strict xhtml. But I'm sure there is a reason we don't do that ... http://archivist.incutio.com/viewlist/css-discuss/73652 http://www.satzansatz.de/cssd/quirksmode.html
I don't think there is any problem to switching to XHTML: http://markmail.org/message/3ax3n6cykpuhgxtz
benallard has come up with this patch: http://hg.xavamedia.nl/mercurial/djc.mq/file/tip/xhtml2 Unfortunately, it still screws up IE (7). So that's a no go for now.
I have different results there: IE 6.0.2800.1106 (W2k) is still brocken (no change) IE 7.0.5730.11 (2003 Server/XP) works now fine. My understanding of my patch is that switch to XHTML only has positive effects (at least for my IE7).
Degrading this to bug. Known workaround: use a sensible browser.
Should we fix this? For example in two weeks, Google will stop supporting IE6 on some of its apps.
No one cares, closing.
--- Bug imported by bugzilla@serpentine.com 2012-05-12 08:56 EDT --- This bug was previously known as _bug_ 1464 at http://mercurial.selenic.com/bts/issue1464